Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Caddyfile config adjustments #345

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

francislavoie
Copy link
Contributor

Some wording adjustments and correctness fixes:

  • "directives" are specifically things within site blocks. Global options are not directives.
  • * is still needed for the root directive for now
  • the worker script example was missing php_server which was misleading because it wouldn't do anything without it.
  • technically, the php_server long-form includes a route wrapper which guarantees the directive order stays as written.

@francislavoie
Copy link
Contributor Author

Build Linux x86_64 binary
Username and password required

Looks like the CI config needs to be updated to avoid having to connect to Docker Hub.

@dunglas dunglas merged commit b9eae57 into dunglas:main Dec 8, 2023
26 of 27 checks passed
@dunglas
Copy link
Owner

dunglas commented Dec 8, 2023

Thanks Francis!

@francislavoie francislavoie deleted the patch-1 branch December 8, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants