docs: xcaddy build flags #385
Conversation
dunglas
force-pushed
the
docs/xcaddy-build-flags
branch
from
9992e7b
to
3d06684
Compare
dunglas
force-pushed
the
docs/xcaddy-build-flags
branch
from
3d06684
to
1584ec3
Compare
There was a problem hiding this comment.
LGTM, fwiw.
This got me thinking though: I wonder if we should set these env vars in the base images (dunglas/frankenphp:latest-builder*) so people don't need to even worry about it?
I suppose it still needs to be documented for native builds, but then that can just be a table of flags required per OS (or put in a Makefile).
| > Otherwise, you may get errors like `PHP Fatal error: Maximum call stack size of 83360 bytes reached during compilation. Try splitting expression` | ||
| > | ||
| > To do so, change the `XCADDY_GO_BUILD_FLAGS` environment variable to something like | ||
| > `XCADDY_GO_BUILD_FLAGS=$'-ldflags "-w -s -extldflags \'-Wl,-z,stack-size=0x80000\'"'` |
There was a problem hiding this comment.
This looks weird to me: $'-ldflags "-w -s...'
Why is the $ there?
There was a problem hiding this comment.
To be able to escape the inner '.
There was a problem hiding this comment.
this syntax does not seem to work. I have in my Dockerfile:
ENV CGO_ENABLED=1 XCADDY_SETCAP=1
ENV XCADDY_GO_BUILD_FLAGS=$'-ldflags "-w -s -extldflags \'-Wl,-z,stack-size=0x80000\'"'
RUN xcaddy build \
And i get an error:
failed to solve: failed to process "$'-ldflags \"-w -s -extldflags \\'-Wl,-z,stack-size=0x80000\\'\"'": unexpected end of statement while looking for matching double-quote
There was a problem hiding this comment.
I suspect it is supposed to be:
ENV XCADDY_GO_BUILD_FLAGS='-ldflags "-w -s -extldflags \'-Wl,-z,stack-size=0x80000\'"'
without the $ since we're not referencing a variable, though I haven't tested it.
There was a problem hiding this comment.
This doesn't work either:
failed to solve: failed to process "'-ldflags \"-w -s -extldflags \\'-Wl,-z,stack-size=0x80000\\'\"'": unexpected end of statement while looking for matching double-quote
This variant is ok in Dockerfile:
ENV XCADDY_GO_BUILD_FLAGS="-ldflags '-w -s -extldflags \'-Wl,-z,stack-size=0x80000\''"
But it fails while building the image:
[ERROR] Splitting arguments failed: -ldflags '-w -s -extldflags \'-Wl,-z,stack-size=0x80000\''
|
Good idea to put these flags in the base builder image (but no Makefile please, |
|
By the way, I think that it would be better to use |
Yeah, I can take care of that and update the documentation. |
For #380 (comment).