Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add sodium to static binaries #415

Merged
merged 1 commit into from
Dec 20, 2023
Merged

ci: add sodium to static binaries #415

merged 1 commit into from
Dec 20, 2023

Conversation

dunglas
Copy link
Owner

@dunglas dunglas commented Dec 19, 2023

Closes #410.

@dunglas dunglas merged commit a571d99 into main Dec 20, 2023
40 checks passed
@dunglas dunglas deleted the ci/static-sodium branch December 20, 2023 14:53
@crazywhalecc
Copy link
Contributor

crazywhalecc commented Dec 26, 2023

Hi @dunglas, I noticed you posted version 1.0.2 on Twitter mentioning this pull request. Adding the sodium extension does not solve this problem, because PHP's password_hash() uses libargon2, not libsodium (also mentioned in the official PHP documentation above).

Last week I merged @mpociot's libargon2 PR and also mentioned in docs.

@dunglas
Copy link
Owner Author

dunglas commented Jan 29, 2024

@crazywhalecc good catch.
As Argon algorithms are also supported by libsodium (but not these constants), and the Argon extension conflicts with libsodium, I suggest keeping it as-is. WDYT?

@crazywhalecc
Copy link
Contributor

@dunglas For FrankenPHP, I feel it's okay to keep the current situation. It is indeed a solvable problem, but the source code of libargon2 still needs to be modified to resolve the conflict on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argon2 support
2 participants