Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes advantage of the smart-pointer stuff from #442 and a small optimization on
go_register_variables
. Through some benchmarks, this is just a tiny bit faster (but within a margin of error, so, at the very least, just as fast).It introduces a (possibly contentious) idea that any C memory created in Go, must be released in Go -- which is new.
I'm also opening a PR with just the optimization in case we don't like this idea.
Beyond this, FrankenPHP cannot be optimized further without improvements in stack switching by Go itself.
I did some benchmarks; there is a slight (but barely detectable) improvement over the other PR:
As you can see, for performance, this is a micro-optimization; however, I believe it can improve code maintenance since it delineates which language owns which bits of memory.