Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require secrets for running tests #45

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Don't require secrets for running tests #45

merged 2 commits into from
Oct 20, 2022

Conversation

withinboredom
Copy link
Collaborator

I just noticed that secrets aren't shared with forks, so tests fail to run. This will at least allow tests to run on PRs from other forks.

@dunglas
Copy link
Owner

dunglas commented Oct 20, 2022

We should also skip the "Docker login" action.

@withinboredom
Copy link
Collaborator Author

I've removed the docker push on PRs (so we're just validating that it builds) and the Docker Login.

@dunglas dunglas merged commit 4a52e0e into dunglas:main Oct 20, 2022
@dunglas
Copy link
Owner

dunglas commented Oct 20, 2022

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@withinboredom @dunglas