optimize cookie handling in request #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com> Signed-off-by: nnnkkk7 <kurodanaoki0711pana@gmail.com>
nnnkkk7
force-pushed
the
fix/handling-cookies
branch
from
cbe458e to
f2796fd
Compare
dunglas
approved these changes
Jan 8, 2024
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the way we handle cookies in the request.
Previously, we were calling
r.Cookies()twice and usingappendto add each cookie to a slice. This could potentially lead to unnecessary overhead due to the function calls and the automatic resizing of the slice when usingappend.The new implementation only calls
r.Cookies()once and uses indexing to set each element in the slice, which should be more efficient.This change should not affect the functionality of the code, but it should improve its performance.