Do not extract embedded app on every execution #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedding a large app (in my case around ~700mb), the app checksum is calculated and the tar is extracted on every execution of the binary.
This slows down the execution (running
php-cli
takes around ~8 seconds) since this process needs to run every time. Instead, we can extract the app only once and re-use the same files for every execution.Another drawback of the current process, is that when the web-server is running (using
php-server
), and you want to run a cli command, then it would remove and re-extract the tar while the webserver is still running.The PR adds the following changes: