Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom php.ini in embedded app #497

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Allow custom php.ini in embedded app #497

merged 2 commits into from
Jan 22, 2024

Conversation

pierredup
Copy link
Contributor

This adds the embedded path to the PHP_INI_SCAN_DIR env variable, so that a custom php.ini can be added to the root of a project.

Fixes #472 and #496

Screenshot 2024-01-22 at 13 55 21

dunglas
dunglas requested changes Jan 22, 2024
View reviewed changes
caddy/php-server.go Outdated Show resolved Hide resolved
@dunglas dunglas merged commit effb580 into dunglas:main Jan 22, 2024
27 checks passed
@dunglas
Copy link
Owner

dunglas commented Jan 22, 2024

Thank you!

@pierredup pierredup deleted the custom-php-ini branch January 22, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php.ini in self-contained binary
2 participants
@pierredup @dunglas