feat: enable resolve_root_symlink by default #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason we didn't enable it by default is to avoid a tiny performance hit from the extra syscall which may be wasteful if the root is never a symlink. Felt better to default to having the best performance rather than best compat because it's not everyone that will use symlinks as a deployment strategy and if they do it's trivial to enable. I have no issue with this being on by default for FrankenPHP. |
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
|
@francislavoie ok! Let's have better compatibility with Laravel and the like (probably helps with Symfony too) and let users create a custom Caddyfile for performance optimizations. |
francislavoie
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having this by default seems to break Laravel apps using
public/storage/.As you know well this part and Laravel, would you mind to review this @francislavoie? Thank you!