-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embed documentation #609
Conversation
I checked back, you cannot explicitly copy stuff if it is mentioned in the .dockerignore. Docker will simply say that the file does not exist. I will check for a different solution and adjust the documentation once i found something. |
Alternatively, we could just add a warning in the docs asking the user to beware the The user could even add |
Also the I mean we could do some little renaming and copy the .env files and vendor folder explicitly into the docker container but i think it is easier to maybe just mention, that the Alternatively, we could move the
part inside the static-build.Dockerfile. Any opinions? |
a27eacb
to
c178b1e
Compare
I generated the translations so maybe some native speaker should check them again ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this solution (when @crazywhalecc fix will be merged).
Co-authored-by: Jerry Ma <jesse2061@outlook.com> Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Thanks @bofalke! |
Ref #608