-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix reading post bodies #686
Conversation
Now that golang/go#15527 is supposedly fixed, this condition should be no-longer needed. Further, if php didn't request enough bytes, this condition would be hit. It appears PHP requests chunks ~2mb in size at a time.
Would it be possible to add a test? |
Tested with the reproducer and 70mb file: Laravel.and.17.more.pages.-.Personal.-.Microsoft.Edge.2024-03-24.11-20-19.mp4 |
Yes... but do we want to? That would mean putting large test file in the repo. |
@withinboredom not necessarily, we can tweak this test for instance: https://github.com/dunglas/frankenphp/blob/main/testdata/large-request.php |
on it! |
Thank you |
Re golang/go#15527, that's an opt-in fix, |
Now that golang/go#15527 is supposedly fixed, this condition should be no-longer needed. Further, if php didn't request enough bytes, this condition would be hit. It appears PHP requests chunks ~2mb in size at a time.
Fixes #122