Yet another workflow change :) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
back-2-95
reviewed
Oct 27, 2022
| @@ -45,6 +45,11 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| dockerfile: [ "Dockerfile", "Dockerfile.alpine" ] | |||
There was a problem hiding this comment.
I guess this line must be remove when using include
There was a problem hiding this comment.
It doesn't have to be. Include matches on the dockerfile key.
|
Things should be building correctly now 🤞 I've made the same change to the test yaml, so you can see what the tags would be by looking at the output of the Docker meta build step. |
dunglas
approved these changes
Oct 27, 2022
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on which build finishes first, either the alpine version or the Debian version will be in the "latest" tag. This change will push a
-alpineversion and make the Debian version the default.:sigh: this stuff is tricky.