feat: autodetect extensions to build for embedded apps #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
changed the title
|
Symfony libs include a lot of polyfills and don't add an extension requirement and many users don't know they'd get better performance by using the extensions instead of the polyfills. Is there some way we can detect these too? Might be out of scope... |
|
Good idea @withinboredom, this could probably be automated. I'll take a look (maybe in another PR). |
|
Actually, Symony polyfills are already automatically replaced by the proper extensions because of how |
dunglas
force-pushed
the
feat/auto-detec-extensions
branch
from
2b544c5
to
f0f3e5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses Composer to automatically detect the required extensions of an app embedded in a standalone binary, and build only these!