Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: Update the way to get C-Thread-Pool #88

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

nitneuk
Copy link
Contributor

@nitneuk nitneuk commented Nov 7, 2022

To use frankenphp as a golib, we need to get C-Thread-Pool as a dependency. As it's not a go dependencies, we need to version it to avoid this error :

$ go build
# github.com/dunglas/frankenphp
frankenphp.c:16:10: fatal error: 'C-Thread-Pool/thpool.h' file not found

We init it using go generate.

@dunglas dunglas merged commit 1820285 into dunglas:main Nov 8, 2022
@dunglas
Copy link
Owner

dunglas commented Nov 8, 2022

Thanks!

flug pushed a commit to flug/frankenphp that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants