perf: Subscriber performance #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review-related changes
# Conflicts: # caddy/go.mod
|
|
|
Thank you very, very much @kevburnsjr! |
|
Humm, it looks like we may have a data race @kevburnsjr: https://github.com/dunglas/mercure/runs/4192750294?check_suite_focus=true |
dunglas
reviewed
Nov 13, 2021
| } | ||
|
|
||
| // Disconnect disconnects the subscriber. | ||
| func (s *Subscriber) Disconnect() { | ||
| s.disconnectedOnce.Do(func() { | ||
| close(s.disconnected) | ||
| close(s.out) |
There was a problem hiding this comment.
This change creates a deadlock. https://github.com/dunglas/mercure/pull/578/files#diff-802f9d2c1e1a0efff7a8474036a024fbbba988f5bdf4650a0b3b4dad99df9ca2R74 can be called after this, and blocks forever.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improves memory usage and throughput with large number of subscribers.