Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsable markup documentation with doxygen #491

Merged
merged 4 commits into from
Feb 22, 2018

Conversation

bebehei
Copy link
Member

@bebehei bebehei commented Feb 20, 2018

This is a start to have the documentation with doxygen, which also contains markup to be able to compile it at the end of the day.

With this, one's able to compile a document to get an overview of the internal structures of dunst.

I've moved my own comments of the queues.c and log.c files to be compliant.

@bebehei
Copy link
Member Author

bebehei commented Feb 21, 2018

Enforcing the documentation comments with YCM can get very profitable. See the GetDocs command.

Copy link
Member

@tsipinakis tsipinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doxygen looks interesting and since the work required to make it work is minimal we can give it ago.

I pointed out some small nitpicks and I also think Doxyfile should be in docs/internal let's not mix user docs with developer docs.

HACKING.md Outdated
- Use `@param` to describe all input parameters
- Documentation comments should start with a double star (`/**`)
- Look forward to properly link all member types
- Functions with an appended `()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 lines needs some more explanation, I can't make much sense of them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an example and also the way to reference symbols/variables.

HACKING.md Outdated
- Add comments to all functions and methods
- Markdown inside the comments is allowed and also desired
- Add the comments to the prototype. Doxygen will merge the protoype and implementation documentation anyways.
Except for **static** methods. Add the documentation header to the implementation and *not to the prototype*.
Copy link
Member

@tsipinakis tsipinakis Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That period is going to confuse people comma would be more appropriate here.

@bebehei bebehei merged commit 28db041 into dunst-project:master Feb 22, 2018
@bebehei bebehei deleted the docs branch March 15, 2018 13:30
karlicoss pushed a commit to karlicoss/dunst that referenced this pull request Mar 21, 2019
Parsable markup documentation with doxygen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants