Unexpected message type handling #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeechu
reviewed
Mar 10, 2021
kombu/transport/pubsub.py
Outdated
| @@ -212,10 +221,22 @@ def _msg_get(self, subscription_path): | |||
| for msg in resp.received_messages: | |||
| if self.temp_cache[subscription_path].full(): | |||
| break | |||
| data = loads(msg.message.data) | |||
There was a problem hiding this comment.
this can still fail in case data is not stringified json?
There was a problem hiding this comment.
@jeechu yes, it will .. i thought of it but expected that message which will be published will be a stringified json. Will update it if that's not the case .
There was a problem hiding this comment.
please update since we want to avoid the process halting
jeechu
reviewed
Mar 10, 2021
kombu/transport/pubsub.py
Outdated
| "Pulled message of unexpected type: ", | ||
| str(type(data)), " data: ", data])) | ||
| # Ack it | ||
| self.subscriber.\ |
There was a problem hiding this comment.
was this the approach discussed? to ack unexpected message?
There was a problem hiding this comment.
@jeechu what do you plan to do with the message instead ?
There was a problem hiding this comment.
for go services, we have not acked any random message, lets do that here too
lets add a log and not ack it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.