Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated constant PROTOCOL_SSLv23 with PROTOCOL_TLS #190

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

AaronAtDuo
Copy link
Contributor

Per https://docs.python.org/3/library/ssl.html:

ssl.PROTOCOL_TLS
Selects the highest protocol version that both the client and server support. Despite the name, this option can select both “SSL” and “TLS” protocols.

New in version 3.6.
ssl.PROTOCOL_SSLv23
Alias for [PROTOCOL_TLS](https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS).

Deprecated since version 3.6: Use [PROTOCOL_TLS](https://docs.python.org/3/library/ssl.html#ssl.PROTOCOL_TLS) instead.

so there should be no functional change with this update, which we can make now that we don't support 3.5 or earlier.

@mbish
Copy link
Contributor

mbish commented Jan 25, 2023

ssl.PROTOCOL_TLS
...
Deprecated since version 3.10

Should we just jump straight to ssl.PROTOCOL_TLS_CLIENT?

@AaronAtDuo
Copy link
Contributor Author

with PROTOCOL_TLS_CLIENT a couple tests fail. After looking into it, I know why, but fixing it technically changes some behavior. So I want to have that as a separate PR / conversation and keep this to solely removing the super-deprecated constant.

@mbish
Copy link
Contributor

mbish commented Jan 25, 2023

Okay that's fine then; we can leave it for later

Copy link
Contributor

@nstojcevich nstojcevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronAtDuo AaronAtDuo merged commit 3835492 into master Jan 25, 2023
@AaronAtDuo AaronAtDuo deleted the update_deprecated_protocol_constant branch January 25, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants