Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_secret_key method to admin.py #266

Merged
merged 1 commit into from
May 8, 2024

Conversation

NotJoePesci
Copy link
Contributor

Added a get_secret_key method to retrieve integration secret key from Admin API

Description

Added a method in admin.py to make calls to the /admin/v1/integrations/[integration_key]/skey endpoint.

Motivation and Context

Despite the documentation indicating this functionality is available and the Admin API providing the correct endpoint it is not currently implemented in the code. I am developing a script to automate the creation of new application integrations and programmatically store them in our organization's secret management solution. When testing the create_integration method I found that it returned all the necessary info except the secret key, when done in this way the secret is obfuscated and thus not suitable for my needs.

Additionally, this will address issue #254.

How Has This Been Tested?

Testing was completed by modifying a development branch of the source and the method has been a number of times while testing my integration script, with no noticeable issues.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Added a get_secret_key method to call the get_secret_key Admin v1 endpoint. Per Issue 254
@AaronAtDuo AaronAtDuo merged commit 89326e3 into duosecurity:master May 8, 2024
5 checks passed
@AaronAtDuo
Copy link
Contributor

Thanks for the PR!

@NotJoePesci NotJoePesci deleted the patch-1 branch May 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants