Updating policy files to reflect the current Duo Desktop policy structure #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Duo Desktop section replaced the device_health_app section in the official admin API docs, but this example was never updated to reflect that. This commit updates this to use the correct section.
The Duo Desktop section replaced the device_health_app section in the official admin API docs, but this example was never updated to reflect that. This commit updates this to use the correct section.
AaronAtDuo
reviewed
May 2, 2024
AaronAtDuo
reviewed
May 2, 2024
AaronAtDuo
reviewed
May 2, 2024
AaronAtDuo
reviewed
May 2, 2024
AaronAtDuo
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The device_health_app section of the policy API was updated to duo_desktop, with one variable renamed (requires_DHA -> requires_duo_desktop) last year, but the two policy examples that use it were not updated alongside it. This PR updates those two values, and also renames the functions that use them to say Duo Desktop instead of Device Health App.
Motivation and Context
This ensures that the current example for Duo Desktop policy is accurate and reflects the name change the Device Health App had last year.
How Has This Been Tested?
Ran both policies and policies_advanced locally to ensure the policy was created correctly and updated with the correct Duo Desktop policies in my admin panel UI
Types of Changes