Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a manual build process to introduce SBOM generation #27

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Add a manual build process to introduce SBOM generation #27

merged 1 commit into from
Jun 18, 2024

Conversation

AaronAtDuo
Copy link
Contributor

Description

Add SBOM generation and scaffold out a workflow to invoke it. Fixes #13

Motivation and Context

When we ship, we'll want to have an SBOM available.

How Has This Been Tested?

N/A

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release prep

@AaronAtDuo
Copy link
Contributor Author

Basically just copied from duo_client_python

@AaronAtDuo AaronAtDuo force-pushed the add_sbom_generation_build_action branch from fa75a1b to e16fc28 Compare June 18, 2024 13:41
yizshi
yizshi reviewed Jun 18, 2024
View reviewed changes
Copy link

@yizshi yizshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this workflow run/tested? I know it only works on dispatch, so maybe it is hard to test for real.

@AaronAtDuo
Copy link
Contributor Author

Has this workflow run/tested? I know it only works on dispatch, so maybe it is hard to test for real.

I'll have to test it after landing it, that's why I made it a manual action. I've run the same commands locally with success though.

yizshi
yizshi approved these changes Jun 18, 2024
View reviewed changes
Copy link

@yizshi yizshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

440622

@AaronAtDuo AaronAtDuo merged commit 476b50a into main Jun 18, 2024
4 checks passed
@AaronAtDuo AaronAtDuo deleted the add_sbom_generation_build_action branch June 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yizshi yizshi yizshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SBOM generation
2 participants
@AaronAtDuo @yizshi