Support for duologsync.log Rotation & Max File Size #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RotatingFileHandler is necessary to prevent the duologsync.log file from increasing in size indefinitely until the disk fills. Requires testing prior to merge, I have not tested this.
jjfallete
changed the title
|
Is this needed so we dont have to manually clear out the log file ever so often? It just grows in size. |
|
@Coldfirex -- exactly. I'm not sure why Duo hasn't responded to this Pull Request. @MarkTripod-Duo maybe you can review? It could be revised to be configurable within the ini as well, this was just a quick and dirty solution we've applied in our env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RotatingFileHandler is necessary to prevent the duologsync.log file from increasing in size indefinitely until the disk fills.
This allows for 3 rotations of the log file (4 total), each capping at 25MB.
We tested this and it appears to be working, but I recommend additional testing or adjusting of the added code as desired.