-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a method for exchanging 2FA token to the SAML response #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET Framework 471 architecture added. Version bump to 1.2.3
AaronAtDuo
reviewed
Jul 15, 2024
AaronAtDuo
reviewed
Jul 15, 2024
AaronAtDuo
reviewed
Jul 15, 2024
AaronAtDuo
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Epic integration uses the SAML response from the Duo server to handle the authentication on it's end. This change introduces the method to retrieve the SAML response in the end of the authentication in exchange to the 2FA token.
Description
Added a method
ExchangeAuthorizationCodeForSamlResponse(string duoCode, string username)
which sends the 2FA token to the Duo server, receives the response and returns the samlResponse part of it.Motivation and Context
This change is a part of the bigger effort of migrating Epic integration to the Universal Prompt from the legacy implementation. For this reason the Universal Prompt needs to support the SAML response.
How Has This Been Tested?
Added unit tests, specific for SAML response. Made sure that the existing unit tests pass
Types of Changes