Simplified the logic for detecting the number of groups

duosecurity · Oct 18, 2024 · 30662aa · 30662aa
1 parent bbec1e2
commit 30662aa
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/compat/groupaccess.c b/compat/groupaccess.c
@@ -64,10 +64,10 @@ ga_init(const char *user, gid_t base)
 #else
 	ngroups = NGROUPS_MAX;
 #  if defined(HAVE_SYSCONF) && defined(_SC_NGROUPS_MAX)
-#    ifndef MAX
-#      define MAX(a,b) (((a)>(b))?(a):(b))
-#    endif
-	ngroups = MAX(NGROUPS_MAX, sysconf(_SC_NGROUPS_MAX));
+	long sys_ngroups_max = sysconf(_SC_NGROUPS_MAX);
+	if (sys_ngroups_max > NGROUPS_MAX) {
+		ngroups = sys_ngroups_max;
+	}
 #  endif
 #endif