Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl From trait for Commitment conversions #433

Closed
CPerezz opened this issue Mar 5, 2021 · 1 comment · Fixed by #492
Closed

Impl From trait for Commitment conversions #433

CPerezz opened this issue Mar 5, 2021 · 1 comment · Fixed by #492
Assignees
@oriolval
Labels
good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Mar 5, 2021

Actually in our repo, we have implemented Commitment as a wrapper type over dusk-bls12_381::G1Affine.

https://github.com/dusk-network/plonk/blob/master/src/commitment_scheme/kzg10/mod.rs#L95-L104

But instead of implementing the conversions from Affine and from Projective on that way, we should implement the From trait.
@CPerezz CPerezz added good first issue Good for newcomers area:API labels Mar 5, 2021
@CPerezz CPerezz pinned this issue Mar 5, 2021
@CPerezz CPerezz added the team:Core Low Level Core Development Team (Rust) label Mar 5, 2021
@oriolval
Copy link
Contributor

Hi mate, I will try to solve the issue!

@ZER0 ZER0 removed the area:API label Mar 16, 2021
oriolval added a commit to oriolval/plonk that referenced this issue Apr 5, 2021
@oriolval
Implement From for Commitment
d07f37a 
Implement From G1Affine and G1Projective for Commitment.
Resolves: dusk-network#433
@oriolval oriolval mentioned this issue Apr 5, 2021
Closed
@CPerezz CPerezz mentioned this issue Apr 12, 2021
Merged
oriolval added a commit to oriolval/plonk that referenced this issue Apr 13, 2021
@oriolval
Implement From for Commitment
a521e79 
Implement From G1Affine and G1Projective for Commitment.
Resolves: dusk-network#433
@CPerezz CPerezz closed this as completed Apr 15, 2021
@CPerezz CPerezz unpinned this issue Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oriolval oriolval

Labels
good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Impl From trait for Commitment oriolval/plonk
Implement From for Commitment oriolval/plonk
3 participants
@ZER0 @oriolval @CPerezz