Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests to integration tests #500

Closed
CPerezz opened this issue Apr 19, 2021 · 0 comments · Fixed by #599
Closed

Move tests to integration tests #500

CPerezz opened this issue Apr 19, 2021 · 0 comments · Fixed by #599
Assignees
@CPerezz
Labels
area:testing everything related to smoke-, unit-, integration-, performance testing good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)
Milestone
Implementing PlonkUp

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Apr 19, 2021

On the review of #495 it was seen that a lot of the tests could be moved to be integration tests instead of unit tests. That could also make it easier to catch API regressions as well as other errors.
@CPerezz CPerezz added area:testing everything related to smoke-, unit-, integration-, performance testing status:minor Low priority improvements team:Core Low Level Core Development Team (Rust) labels Apr 19, 2021
@autholykos autholykos added team:R&D Research & Development (Cryptographic Protocol) and removed team:Core Low Level Core Development Team (Rust) labels Jul 1, 2021
@autholykos autholykos added team:Core Low Level Core Development Team (Rust) and removed team:R&D Research & Development (Cryptographic Protocol) labels Jul 20, 2021
@ZER0 ZER0 added the good first issue Good for newcomers label Jul 20, 2021
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 6, 2021
@ZER0 ZER0 removed the status:minor Low priority improvements label Oct 6, 2021
@ZER0 ZER0 mentioned this issue Oct 13, 2021
Merged
ureeves added a commit that referenced this issue Oct 13, 2021
@ureeves
Change unit tests to be integration tests
b7bc167 
- Change test_full() to be an integration test
- Change CI to run all binaries generated by cargo test --no-run

Resolves: #500
@ureeves ureeves linked a pull request Oct 13, 2021 that will close this issue
Change unit tests as integration tests when possible #599
Merged
ureeves added a commit that referenced this issue Oct 13, 2021
@ureeves
Change unit tests as integration tests when possible (#599)
b7ac059 
Change unit tests to be integration tests

- Change test_full() to be an integration test
- Change CI to run all binaries generated by `cargo test --no-run`

Resolves: #500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
area:testing everything related to smoke-, unit-, integration-, performance testing good first issue Good for newcomers team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
Implementing PlonkUp
Development

Successfully merging a pull request may close this issue.

Change unit tests as integration tests when possible dusk-network/plonk
3 participants
@ZER0 @autholykos @CPerezz