Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iter().product() or fold instead of for loops in Permutation mod #562

Closed
CPerezz opened this issue Aug 18, 2021 · 0 comments · Fixed by #623
Closed

Use iter().product() or fold instead of for loops in Permutation mod #562

CPerezz opened this issue Aug 18, 2021 · 0 comments · Fixed by #623
Labels
good first issue Good for newcomers status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)
Milestone
Implementing PlonkUp

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Aug 18, 2021

This is a clear example, looks like current_component is a tuple of elements of the same type; if it was an array you could just loop it or call iter().product() or fold.

Originally posted by @ZER0 in #561 (comment)
@CPerezz CPerezz added good first issue Good for newcomers status:minor Low priority improvements team:Core Low Level Core Development Team (Rust) labels Aug 18, 2021
@CPerezz CPerezz mentioned this issue Aug 18, 2021
Merged
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 6, 2021
ZER0 added a commit that referenced this issue Oct 15, 2021
@ZER0
Change to arrays some tuples in permutation module
286b75d 
Resolves: #562
@ZER0 ZER0 mentioned this issue Oct 15, 2021
Merged
@ZER0 ZER0 linked a pull request Oct 15, 2021 that will close this issue
Change to arrays some tuples in permutation module #623
Merged
ZER0 added a commit that referenced this issue Oct 15, 2021
@ZER0
Change to arrays some tuples in permutation module
e0af78b 
Resolves: #562
ZER0 added a commit that referenced this issue Oct 15, 2021
@ZER0
Change to arrays some tuples in permutation module (#623)
6a580da 
Resolves: #562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers status:minor Low priority improvements team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
Implementing PlonkUp
Development

Successfully merging a pull request may close this issue.

Change to arrays some tuples in permutation module dusk-network/plonk
2 participants
@ZER0 @CPerezz