Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add From extended point to PublicInputValue #573

Closed
vlopes11 opened this issue Sep 16, 2021 · 0 comments · Fixed by #574
Closed

Add From extended point to PublicInputValue #573

vlopes11 opened this issue Sep 16, 2021 · 0 comments · Fixed by #574
Assignees
@vlopes11

Comments

@vlopes11
Copy link
Contributor

The PublicInputValue benefits from From<AffinePoint> but doesn't have a From<ExtendedPoint> implementation.

Since ExtendedPoint implements Into<AffinePoint>, that implementation is trivial for PublicInputValue
@vlopes11 vlopes11 self-assigned this Sep 16, 2021
vlopes11 added a commit that referenced this issue Sep 16, 2021
@vlopes11
Add From extended point to PublicInputValue
8806b26 
`PublicInputValue` implements `From<JubJubAffine>`.

Since `JubJubExtended` implements `Into<JubJubAffine>`, the
implementation of `From<JubJubExtended>` for `PublicInputValue` is
trivial.

This will save the consumers of the API some additional and unnecessary
conversions.

Resolves #573
@vlopes11 vlopes11 mentioned this issue Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlopes11 vlopes11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add From extended point to PublicInputValue dusk-network/plonk
1 participant
@vlopes11