Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Constraint to describe the circuit #608

Closed
vlopes11 opened this issue Oct 8, 2021 · 0 comments · Fixed by #606
Closed

Add Constraint to describe the circuit #608

vlopes11 opened this issue Oct 8, 2021 · 0 comments · Fixed by #606
Assignees
@vlopes11
Labels
team:Core Low Level Core Development Team (Rust)
Milestone
Implementing PlonkUp

Comments

@vlopes11
Copy link
Contributor

vlopes11 commented Oct 8, 2021

Describe what you want implemented
Constraint are builder structures that will allow the user to specify the circuits without using complicated method arguments where the order of the selectors isn't concise or uniform.

Describe "Why" this is needed
Currently the API is over-complicated and misleading because many gates have different implementations that are not always documented correctly or even implemented securely.

Centralizing the circuit description is a major improvement in terms of usability and security since a single implementation of the selectors will either always be correct or always be wrong, not depending on methods provided by the composer itself.

Describe alternatives you've considered
Refactoring all the functions of the composer to achieve uniformity is a viable alternative, but it will not solve the problem of the complexity of the arguments of the gates

Additional context
This improvement will facilitate future API refactoring to build the circuit using DSLs.
@vlopes11 vlopes11 added the team:Core Low Level Core Development Team (Rust) label Oct 8, 2021
@vlopes11 vlopes11 self-assigned this Oct 8, 2021
vlopes11 added a commit that referenced this issue Oct 8, 2021
@vlopes11
Add Constraint and Selector types
ed3edbb 
`Constraint` will introduce a fail-safe type that can be used to
describe a circuit. It will replace any composer argument that takes the
circuit description/selector polynomials.

`Selector` will allow the user to extract specific coefficients from the
constraint representation.

Resolves #608
@vlopes11 vlopes11 mentioned this issue Oct 8, 2021
Merged
vlopes11 added a commit that referenced this issue Oct 8, 2021
@vlopes11
Add Constraint types to describe circuits
b217133 
`Constraint` will introduce a fail-safe type that can be used to
describe a circuit. It will replace any composer argument that takes the
circuit description/selector polynomials.

Resolves #608
vlopes11 added a commit that referenced this issue Oct 8, 2021
@vlopes11
Add Constraint types to describe circuits (#606)
7782406 
`Constraint` will introduce a fail-safe type that can be used to
describe a circuit. It will replace any composer argument that takes the
circuit description/selector polynomials.

Resolves #608
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 8, 2021
@ZER0 ZER0 linked a pull request Oct 8, 2021 that will close this issue
Add Constraint and Selector types #606
Merged
@ZER0 ZER0 closed this as completed Oct 8, 2021
vlopes11 added a commit that referenced this issue Oct 18, 2021
@vlopes11
Add Constraint types to describe circuits (#606)
8e865fc 
`Constraint` will introduce a fail-safe type that can be used to
describe a circuit. It will replace any composer argument that takes the
circuit description/selector polynomials.

Resolves #608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlopes11 vlopes11

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
Implementing PlonkUp
Development

Successfully merging a pull request may close this issue.

Add Constraint and Selector types dusk-network/plonk
2 participants
@ZER0 @vlopes11