Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rkyv related traits #697

Closed
ureeves opened this issue Jul 28, 2022 · 0 comments · Fixed by #698
Closed

Implement rkyv related traits #697

ureeves opened this issue Jul 28, 2022 · 0 comments · Fixed by #698
Assignees
Labels
team:Core Low Level Core Development Team (Rust) type:feature implementing a new feature

Comments

@ureeves
Copy link
Member

ureeves commented Jul 28, 2022

Describe what you want implemented
rkyv related traits should be implemented for at least Proof to allow for passing them through the host/VM boundary.

Describe "Why" this is needed
This is necessary to be able to pass these structures to a smart contract running on the virtual machine.

Describe alternatives you've considered
N/A

Additional context
The job of serialization and de-serialization used to be performed by canonical. Due to the increased costs it entailed, we decided to architect the new VM to allow rkyvable used as transaction arguments.

@ureeves ureeves added type:feature implementing a new feature team:Core Low Level Core Development Team (Rust) labels Jul 28, 2022
@ureeves ureeves self-assigned this Jul 28, 2022
ureeves pushed a commit that referenced this issue Jul 28, 2022
ureeves pushed a commit that referenced this issue Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:Core Low Level Core Development Team (Rust) type:feature implementing a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant