Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix canon feature related compilation errors #451

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Fix canon feature related compilation errors #451

merged 2 commits into from
Mar 10, 2021

Conversation

CPerezz
Copy link
Contributor

@CPerezz CPerezz commented Mar 10, 2021

  • Remove Canon impl for Proof.
  • Make the std::Error impl behind std flag.

Resolves: #450

Fix canon feature related compilation errors
f7af92c 
- Remove `Canon` impl for `Proof`.
- Make the `std::Error` impl behind `std` flag.

Resolves: #450
@CPerezz CPerezz added the team:Core Low Level Core Development Team (Rust) label Mar 10, 2021
@CPerezz CPerezz requested a review from ZER0 March 10, 2021 14:18
ZER0
ZER0 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPerezz CPerezz merged commit 399f9db into release-0.6 Mar 10, 2021
@CPerezz CPerezz deleted the fix_canon_feature_errs branch March 10, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZER0 ZER0 ZER0 approved these changes

Assignees
No one assigned
Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CPerezz @ZER0