Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tests for logic component #745

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Mar 13, 2023

Resolves #734

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #745 (2584565) into master (e676741) will increase coverage by 0.28%.
The diff coverage is 96.68%.

❗ Current head 2584565 differs from pull request most recent head 8843fc6. Consider uploading reports for the commit 8843fc6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   84.70%   84.99%   +0.28%     
==========================================
  Files          53       53              
  Lines        4099     4078      -21     
==========================================
- Hits         3472     3466       -6     
+ Misses        627      612      -15     
Impacted Files Coverage Δ
tests/assert_scalar.rs 84.12% <90.00%> (ø)
tests/append_gate.rs 92.68% <90.90%> (+3.64%) ⬆️
tests/logic.rs 94.16% <97.19%> (+0.48%) ⬆️
tests/assert_point.rs 83.05% <100.00%> (+0.59%) ⬆️
tests/boolean.rs 65.00% <100.00%> (+1.84%) ⬆️
tests/common/mod.rs 76.47% <100.00%> (+1.47%) ⬆️
tests/ecc.rs 88.49% <100.00%> (+0.42%) ⬆️
tests/select_bls.rs 87.80% <100.00%> (+0.46%) ⬆️
tests/select_point.rs 90.09% <100.00%> (+0.18%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e676741...8843fc6. Read the comment docs.

With the new setup one can specify the circuit for the compililation
@moCello moCello marked this pull request as draft March 13, 2023 15:21
@moCello moCello marked this pull request as ready for review March 13, 2023 15:53
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit 1ba3f9d into master Mar 14, 2023
@moCello moCello deleted the mocello/tests_logic branch March 14, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor and add tests for logic components
2 participants