Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and fix for panic on prove #761

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

moCello
Copy link
Member

@moCello moCello commented Aug 14, 2023

This fixes a panic on proof creation when the circuit to prove is larger than in the provers circuit description

@moCello moCello linked an issue Aug 14, 2023 that may be closed by this pull request
@moCello moCello self-assigned this Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #761 (27e22be) into master (66f8d64) will decrease coverage by 0.02%.
The diff coverage is 73.91%.

❗ Current head 27e22be differs from pull request most recent head 13e90ac. Consider uploading reports for the commit 13e90ac to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   85.07%   85.05%   -0.02%     
==========================================
  Files          56       57       +1     
  Lines        4343     4364      +21     
==========================================
+ Hits         3695     3712      +17     
- Misses        648      652       +4     
Files Changed Coverage Δ
src/error.rs 0.00% <0.00%> (ø)
tests/size.rs 75.00% <75.00%> (ø)
src/composer.rs 91.11% <100.00%> (+0.05%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f8d64...13e90ac. Read the comment docs.

@moCello moCello marked this pull request as ready for review August 14, 2023 13:48
This fixes a panic on proof creation when the circuit to prove is
larger than in the provers circuit description

Resolves: #760
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 👍

@moCello moCello merged commit 8691d2b into master Aug 16, 2023
5 checks passed
@moCello moCello deleted the mocello/pi_outofbounds branch August 16, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proof creation crashes
3 participants