-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make code to match the last Plonk paper #830
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #830 +/- ##
==========================================
+ Coverage 85.32% 85.44% +0.11%
==========================================
Files 57 57
Lines 3687 3723 +36
==========================================
+ Hits 3146 3181 +35
- Misses 541 542 +1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR makes the protocol to match the last version of the Plonk paper. Furthermore, it includes a document specifying our implementation of Plonk, which deviates from the original one to include custom gates.
Main changes
The main changes are:
r
.z_challenge
tor
.z_challenge
by the quotient polynomial fromr
. As such, the quotient polynomial is not needed to computeW_z(X)
.r_0_eval
. As such, the verifier no longer needs to receiver_eval
.z_challenge
by the quotient polynomial commitment from[D]_1
. As such, the verifier doesn't need to computet_eval
, as it is not needed to compute[E]_1
.u_challenge
when computing the polynomial commitment[D]_1
.Minor changes
Some minor changes have been addressed:
Collateral effects
The above changes have led to the following collateral effects:
6ms
to3.7ms
onApple M1
).1 BlsScalar
.