-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-wallet: Scaffold Token pages #3442
base: master
Are you sure you want to change the base?
Conversation
c37e616
to
167f405
Compare
1df7467
to
2e643e2
Compare
Resolves #3415
f90f229
to
e297ea8
Compare
@@ -41,6 +41,11 @@ | |||
}, | |||
]; | |||
|
|||
$: if (import.meta.env.VITE_FEATURE_TOKENS === "true") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to be reactive; you can just:
const navigation [ /* ... */ ];
if (import.meta.env.VITE_FEATURE_TOKENS === "true") {
navigation.push({ link: "/tokens", title: "Tokens" });
}
A couple of questions here:
|
I think so.
Yeah, this is also possible. But I didn't want to fiddle too much with the types, until we have some API spec. Otherwise it's just back and forth changing stuff on our end. I know that @Neotamandua still haven't started working on it yet, but would be good to have some drafts / plan on how it would look like. |
Fair enough. |
Resolves #3415
Visuals:
Note: I have tweaked the current Transaction type, rather than introducing a new one for the Token's Transaction. I think both approaches have flaws – one avoids overcomplicating the code, the another one introduces potentially unneeded changes to code that is currently on production. I spoke with Thomas yesterday, seems like the Token's Transaction type will be different than the Transactions – however, I still think we should still try to make the types compatible with one another, as we are in a desperate need of simplification of the Explorer.