Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #106

Closed
moCello opened this issue Apr 10, 2024 · 0 comments · Fixed by #107 or #110
Closed

Update dependencies #106

moCello opened this issue Apr 10, 2024 · 0 comments · Fixed by #107 or #110
Assignees
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@moCello
Copy link
Member

moCello commented Apr 10, 2024

Summary

Update all dusk dependencies versions:
lib from version to version
dusk-jubjub 0.13 0.14
dusk-plonk 0.16 0.19
dusk-poseidon 0.31 0.33
poseidon-merkle 0.3 0.5
phoenix-core 0.21 0.26
stake-contract-types 0.0.1-rc.2 0.1.0-rc
rusk-abi 0.12.0-rc.0 0.13.0-rc
rename lib:
old name at version new name at version
bls12_381-sign 0.6 bls12_381-bls 0.2
dusk-schnorr 0.18 jubjub-schnorr 0.2
deprecate dusk-pki move objects to jubjub-schnorr and phoenix-core:
dusk-pki struct or trait moved to notes
SecretKey jubjub_schnorr::SecretKey used as NoteSecretKey
PublicKey jubjub_schnorr::PublicKey used as NotePublicKey
SecretSpendKey phoenix_core::SecretKey now only called SecretKey
PublicSpendKey phoenix_core::PublicKey now only called PublicKey
StealthAddress phoenix_core::StealthAddress -
ViewKey phoenix_core::ViewKey -
Ownable phoenix_core::Ownable -

With the keys changing their names, this PR also updates function and variable names accordingly:

  • ssk -> sk
  • psk -> pk
  • SecretKey and PublicKey from the bls12_381-bls lib will be imported as StakeSecretKey and StakePublicKey respectively

These name changes have implications on some wallet functions:

  • Rename Wallet::public_key to Wallet::stake_public_key
  • Rename Wallet::public_spend_key to Wallet::public_key
  • Rename derive_sk to derive_stake_sk
  • Rename derive_ssk to derive_sk
  • Rename retrieve_sk to retrieve_stake_sk
  • Rename retrieve_ssk to retrieve_sk
  • Rename ffi::public_spend_key to ffi::public_key
  • Rename UnprovenTransactionInput::pk_r to note_pk_prime
  • Rename get_public_key_rkyv_serialized to get_stake_pk_rkyv_serialized
@HDauven HDauven added the type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) label Apr 24, 2024
@HDauven HDauven linked a pull request Apr 24, 2024 that will close this issue
This was referenced May 1, 2024
moCello added a commit that referenced this issue May 8, 2024
moCello added a commit that referenced this issue May 8, 2024
moCello added a commit that referenced this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants