Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction needs to serialize as transfer-contract::Call::Execute #31

Closed
ureeves opened this issue Jan 28, 2022 · 0 comments · Fixed by #32
Closed

Transaction needs to serialize as transfer-contract::Call::Execute #31

ureeves opened this issue Jan 28, 2022 · 0 comments · Fixed by #32
Assignees
@ureeves
Labels
area:wallet Issues related to the wallet functionalities exposed by the node fix:bug Something isn't working mark:testnet

Comments

@ureeves
Copy link
Member

ureeves commented Jan 28, 2022

Describe the bug
The Transaction type is currently Canon but doesn't serialize in the same way. This blocks passing transactions through the state with CanonError::InvalidEncoding.

To Reproduce
Try and pass a transaction through a NetworkState::Execute.

Expected behaviour
Transactions are expected to pass through NetworkState without a problem.

Logs/Screenshot
N/A

Platform
N/A

Additional context
The problem is likely to be in the Option<Crossover>.
@ureeves ureeves added area:wallet Issues related to the wallet functionalities exposed by the node fix:bug Something isn't working mark:testnet labels Jan 28, 2022
@ureeves ureeves self-assigned this Jan 28, 2022
ureeves pushed a commit that referenced this issue Jan 28, 2022
Fix Canon encoding of Transaction
d735f34 
The transaction is required to encode into a `Canon` representation that
is equivalent to the one of `transfer-contract::Call::Execute`. This
ensures that it can pass directly through the virtual machine.

Resolves: #31
@ureeves ureeves mentioned this issue Jan 28, 2022
Merged
@moCello moCello mentioned this issue Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ureeves ureeves

Labels
area:wallet Issues related to the wallet functionalities exposed by the node fix:bug Something isn't working mark:testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Canon encoding of Transaction dusk-network/wallet-core
1 participant
@ureeves