Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return amount spendable in get_balance #53

Closed
ureeves opened this issue Mar 14, 2022 · 0 comments · Fixed by #54
Closed

Return amount spendable in get_balance #53

ureeves opened this issue Mar 14, 2022 · 0 comments · Fixed by #54
Assignees
@ureeves
Labels
area:wallet Issues related to the wallet functionalities exposed by the node mark:testnet team:Core Low Level Core Development Team (Rust)

Comments

@ureeves
Copy link
Member

ureeves commented Mar 14, 2022

Describe what you want implemented
Since there is a limit to the amount of notes a user can spend in a single transaction, this leads to a natural limit to the amount a user can spend in a single transaction. This amount should be computed and returned in get_balance.

Describe "Why" this is needed
This is necessary so users can get some feedback about how much they can spend, prior to actually trying to spend more than they can.

Describe alternatives you've considered
N/A

Additional context
N/A
@ureeves ureeves added area:wallet Issues related to the wallet functionalities exposed by the node mark:testnet team:Core Low Level Core Development Team (Rust) labels Mar 14, 2022
@ureeves ureeves self-assigned this Mar 14, 2022
@ureeves ureeves mentioned this issue Mar 14, 2022
Closed
ureeves pushed a commit that referenced this issue Mar 14, 2022
Change get_balance to also return max spendable
8500101 
The `BalanceInfo` struct is introduced, returned by `get_balance` and
contains both the total balance available, and the maximum amount
spendable in a single transaction.

Resolves: #53
@ureeves ureeves mentioned this issue Mar 14, 2022
Merged
ureeves pushed a commit that referenced this issue Mar 14, 2022
Change get_balance to also return max spendable
8cf4170 
The `BalanceInfo` struct is introduced, returned by `get_balance` and
contains both the total balance available, and the maximum amount
spendable in a single transaction.

Resolves: #53
@moCello moCello mentioned this issue Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ureeves ureeves

Labels
area:wallet Issues related to the wallet functionalities exposed by the node mark:testnet team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change get_balance to also return max spendable dusk-network/wallet-core
1 participant
@ureeves