Pass fee and crossover in execute to fix wrong transaction hash #85
Conversation
Use the same exact rng provide when generating output notes
There was a problem hiding this comment.
Some things I'd like to see changed or addressed. I second @Neotamandua 's comment.
assets/dusk_wallet_core.wasm
Outdated
There was a problem hiding this comment.
This is a build artifact isn't it? As such it should not be added in this commit
There was a problem hiding this comment.
There's still an artifact here. Do we really want to keep it?
There was a problem hiding this comment.
We decided to keep it because one of the tests uses it
Daksh14
force-pushed
the
fee_crossover_rng_fix
branch
2 times, most recently
from
70078b1
to
e9ab926
Compare
Fix clippy warnings
Daksh14
force-pushed
the
fee_crossover_rng_fix
branch
from
1211c63
to
dbaa79f
Compare
|
We will need to regenerate the wasm with this PR and then release @ureeves Ready for re-review |
There was a problem hiding this comment.
@Daksh14 and I had a talk and decided that the Type suffix is definitely a *nit, and since the WASM payload was already there, we can deal with it in a subsequent PR. Since those were the only two objections, I'm approving. LGTM!
|
Follow up #94 |
Use the same exact rng provided when generating output notes
Closes #84