Adaptation of the feedback process to include isConversationShared #9672
Conversation
front/package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "dependencies": { | |||
| "@auth0/nextjs-auth0": "^3.5.0", | |||
| "@dust-tt/client": "file:../sdks/js", | |||
| "@dust-tt/sparkle": "^0.2.350", | |||
| "@dust-tt/sparkle": "^0.2.351-alpha", | |||
There was a problem hiding this comment.
Currently testing on front-edge, sparkle is not published yet, I will change once we publish it :)
| {agentLastAuthor?.firstName} {agentLastAuthor?.lastName} | ||
| </Page.P> | ||
| <div className="mb-4 mt-2 flex flex-col gap-2"> | ||
| <Page.P variant="secondary">Your feedback goes to:</Page.P> |
There was a problem hiding this comment.
I think we discussed this but this is really a lie. The feedback does not go to the last author in particular and it is actually visible by the entire workspace.
Can we tweak the wording here? 🙏
There was a problem hiding this comment.
Happy to change it, we could go with "Your feedback is publicly available. The last assistant author is:", feel free to suggest anything
There was a problem hiding this comment.
This is much closer to the truth 👍
There was a problem hiding this comment.
publicly is a bit of an exagerration. Your feedback is available to the workspace maybe?
| Your feedback will be sent to: | ||
| <br /> | ||
| {agentLastAuthor?.firstName} {agentLastAuthor?.lastName} | ||
| Your feedback is publicly available within the workspace. The last |
There was a problem hiding this comment.
publicly is scary.
Your feedback is available to editors of the assistant.
…9672) * Displaying feedback for custom assistants only. Handling of isConversationShared * Renamed isToRemove, slight popover margin adjustments * Npm-d on alpha sparkle version * comment nitpick * Changed feedback sharing message * feedback privacy disclaimer updated * New wording * Bumped sparkle version
…9672) * Displaying feedback for custom assistants only. Handling of isConversationShared * Renamed isToRemove, slight popover margin adjustments * Npm-d on alpha sparkle version * comment nitpick * Changed feedback sharing message * feedback privacy disclaimer updated * New wording * Bumped sparkle version
Description
Screen.Recording.2025-01-02.at.14.02.37.mov
Risk
Break feedback
Deploy Plan
Deploy Front, after spark is published