fix: don't expose hyper HeaderMap #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolu
reviewed
Jun 3, 2024
eventsource-client/src/error.rs
Outdated
| let key = key.as_str(); | ||
| let value = match value.to_str() { | ||
| Ok(value) => value, | ||
| Err(err) => return Err(Error::InvalidParameter(Box::new(err))), |
There was a problem hiding this comment.
This error is still hyper specific no?
Maybe get(&str) -> Result to make this more straightforward?
There was a problem hiding this comment.
This error is still hyper specific no?
It's eventsource specific
There was a problem hiding this comment.
Maybe get(&str) -> Result to make this more straightforward?
Makes the thing kind of painful to use IMHO
spolu
approved these changes
Jun 3, 2024
|
@spolu Still I think it's not ideal because this error is meant for invalid request params. I'm going to add an |
spolu
reviewed
Jun 3, 2024
| @@ -58,6 +70,8 @@ pub enum Error { | |||
| MalformedLocationHeader(Box<dyn std::error::Error + Send + Sync + 'static>), | |||
| /// Reached maximum redirect limit after encountering Location headers. | |||
| MaxRedirectLimitReached(u32), | |||
| // Invalid response header. | |||
| InvalidResponseHeader(Box<dyn std::error::Error + Send + Sync + 'static>), | |||
There was a problem hiding this comment.
Not sure it will fly with them as this list is meant for the main loop no ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want our ResponseWrapper to not expose any of the
hypertypes.This commit changes the return value of
headersto return aHashMap<&str, &str>instead of ahyper::HeaderMap