Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push is really concat #2

Open
dustingetz opened this issue Nov 29, 2015 · 1 comment
Open

push is really concat #2

dustingetz opened this issue Nov 29, 2015 · 1 comment

Comments

@dustingetz
Copy link
Owner

No description provided.

@dustingetz
Copy link
Owner Author

Daniel Miladinov - 8:11 AM
So I’m looking at your update-in issue, push is concat - #2
Do you want to add concat as an alias to push, or replace push with concat altogether (I imagined I’d still call out to react-addons/update:$push underneath, because it’s doing the right thing)

Dustin Getz - 8:33 AM
the isuse i believe is that addons.$push takes an array argument
which confuses me and everyone else when we intuitively pass it a value and it fails

Dustin Getz - 8:49 AM
however the change i suggest in that issue breaks backwards compat, so i dont know, i will need to at least consult Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dustingetz