-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpg encryption support #162
Conversation
|
the idea of the server managing the encryption instead of the client makes it not end to end encrypted, plus the password could be read by the server anyways. |
@stefanbenten what do you think of this? |
do not reference server public hosting version in encrypt/decrypt headers example
I'll review this today :) |
@stefanbenten did you have a chance to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small code styling comments, overall looks good.
Will do a staging test now, if you do not hear from me until midnight UTC, assume it worked :)
Has this been tested yet? |
going to merge soon |
indeed will wait #527 before |
X-Encrypt-Password
/X-Decrypt-Password
headers work seemingless as in gpg piping shell examples