Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build more binary releases #395

Merged
merged 18 commits into from
Aug 19, 2021
Merged

Conversation

wc7086
Copy link
Contributor

@wc7086 wc7086 commented Aug 11, 2021

No description provided.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
@aspacca
Copy link
Collaborator

aspacca commented Aug 11, 2021

@wc7086 thanks for the contribution, please see my comments

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@wc7086
Copy link
Contributor Author

wc7086 commented Aug 12, 2021

This is modified from the automated yaml of other projects. Because I don’t know everyone’s preferences, and I didn’t consider some automated programs, so I didn’t write very well. It has now been modified according to your requirements.

@wc7086
Copy link
Contributor Author

wc7086 commented Aug 12, 2021

I made some mistakes which led to more commits. Should I open another PR or you use the squash mode to merge my commits?

@stefanbenten
Copy link
Collaborator

We can squash them 👍

.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/build/friendly-filenames.json Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@wc7086
Copy link
Contributor Author

wc7086 commented Aug 13, 2021

In order to facilitate the tracking of the problem, I think that the version number should be written into the cmd.go and the Commit ID should be added. What do you think?

@aspacca
Copy link
Collaborator

aspacca commented Aug 18, 2021

In order to facilitate the tracking of the problem, I think that the version number should be written into the cmd.go and the Commit ID should be added. What do you think?

that's what happens here: https://github.com/dutchcoders/transfer.sh/pull/395/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R126

@wc7086
Copy link
Contributor Author

wc7086 commented Aug 18, 2021

that's what happens here: https://github.com/dutchcoders/transfer.sh/pull/395/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R126

This is the tag, not the Commit ID.
I circled the Commit ID in the image below.
image

@aspacca
Copy link
Collaborator

aspacca commented Aug 18, 2021

This is the tag, not the Commit ID.

the tag points to a commit, if you build from a not tagged commit it will print something like v1.x.x-commit

@aspacca aspacca merged commit 788dfa2 into dutchcoders:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants