-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build more binary releases #395
Conversation
@wc7086 thanks for the contribution, please see my comments |
This is modified from the automated yaml of other projects. Because I don’t know everyone’s preferences, and I didn’t consider some automated programs, so I didn’t write very well. It has now been modified according to your requirements. |
I made some mistakes which led to more commits. Should I open another PR or you use the squash mode to merge my commits? |
We can squash them 👍 |
In order to facilitate the tracking of the problem, I think that the version number should be written into the cmd.go and the Commit ID should be added. What do you think? |
that's what happens here: https://github.com/dutchcoders/transfer.sh/pull/395/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R126 |
This is the tag, not the Commit ID. |
the tag points to a commit, if you build from a not tagged commit it will print something like |
No description provided.