Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POA needles indexing #57

Merged
merged 59 commits into from
Jul 11, 2024
Merged

Remove POA needles indexing #57

merged 59 commits into from
Jul 11, 2024

Conversation

dvdvideo1234
Copy link
Owner

This will use the vector and angle unpack method to basically transform

  stSpawn.HPnt:SetUnpacked(hdPOA.P[cvX], hdPOA.P[cvY], hdPOA.P[cvZ])
  stSpawn.HOrg:SetUnpacked(hdPOA.O[cvX], hdPOA.O[cvY], hdPOA.O[cvZ])
  stSpawn.HAng:SetUnpacked(hdPOA.A[caP], hdPOA.A[caY], hdPOA.A[caR])

to become

  stSpawn.HPnt:SetUnpacked(hdPOA.P:Get())
  stSpawn.HOrg:SetUnpacked(hdPOA.O:Get())
  stSpawn.HAng:SetUnpacked(hdPOA.A:Get())

Removed: `SubVectorXYZ`, `AddVectorXYZ`, `AddVector` and `SubVector` are not needed anymore
Renamed: `MakePOA` to `NewPOA`
Removed: Third argument of `getPieceOffset` wire not needed anymore
Utilize: Vector `IsZero`
@dvdvideo1234
Copy link
Owner Author

Hey, @Grocel

With this modification I was able to remove the different indexing nonsense. The method POA:Get() works like Vector:Unpack()

@dvdvideo1234 dvdvideo1234 removed the bug label Apr 26, 2024
@dvdvideo1234
Copy link
Owner Author

This PR is big as it is intended to be. Next PR may remove NewXY 2D point creation and just use vectors X/Y coordinates.

Removed: Internal format values for `GetReport`
Added: Source model for errors importing POA
Added: Log control client-side in TM button
Fixed: Localizing `select` lua function
Fixed: Attachment ID to return extracted model second
Fixed: Angle being updated to POA instead of the point
Added: Extra log for model `X` when processing its attachments
Changed: `Record not located` to `Error missing`
TODO: Test importing and exporting DSV
Fixed: Various runtime errors affecting `ExportTypeAR`
Updated: Export DB manual mapped to right click
Fixed: Ghosts not being ignored by the duplication
Fixed: Timer attach and restart methods
Fixed: Memory manager fail on one navigation step
Fixed: Hook info returning empty toolin some cases
Fixed: Ghosting now utilizes
Fixed: Flip over remove errors during spawn and validation
Added: Active tool validation in some hooks
Updated: Database storage `CL/SV` to `LUA/SQL`
Removed: Usage of Depricated STRING:Implode(TABLE)
Removed: `TOOL:Deploy` as it is not needed anymore
Removed: Usage of `oPly:GetNWBool(gsToolPrefL.."enghost")`
Fixed: Processing DSV generating table indexing  errors
Added: Use library unpack method for normal angle
Added: Extra log on timer navigation fail
@dvdvideo1234 dvdvideo1234 merged commit 96f8942 into master Jul 11, 2024
1 check passed
@dvdvideo1234 dvdvideo1234 deleted the OOP-POA branch July 11, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant