This repository has been archived by the owner on Sep 11, 2018. It is now read-only.
Fixed issue 'Unexpected key counter found in previous state received … #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by the reducer' when added window.__INITIAL_STATE of { counter: 1 }. The counter reducer is async injected, so there no reducer to key 'counter' when combineReducers in createStore intially. Therefore a warning from combineReducers shows in non-production mode, but the initial state of { counter: 1 } is removed in production mode
Current coverage is 71.64% (diff: 66.66%)@@ master #1059 diff @@
==========================================
Files 12 12
Lines 62 67 +5
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 45 48 +3
- Misses 17 19 +2
Partials 0 0
|
shendepu
force-pushed
the
fix-initial-state-with-async-reducer-when-create-store
branch
from
29074ac
to
d2355a4
Compare
|
Nice! We were also running into this issue. Took us a long time to debug. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…by the reducer' when added window.__INITIAL_STATE of { counter: 1 }. The counter reducer is async injected, so there no reducer to key 'counter' when combineReducers in createStore intially. Therefore a warning from combineReducers shows in non-production mode, but the initial state of { counter: 1 } is removed in production mode