Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipenv instead of plain requirements.txt #6

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Add pipenv instead of plain requirements.txt #6

merged 1 commit into from
Oct 2, 2017

Conversation

marius92mc
Copy link
Contributor

This PR adds pipenv for easier management of virtual environment and pip.

@dvf
Copy link
Owner

dvf commented Oct 2, 2017

Great! Thanks @marius92mc

Do we need the lockfile?

@marius92mc
Copy link
Contributor Author

I could easily remove it and add it to .gitignore, but according to this, it is encouraged.

Will drop it if you consider better that way, just let me know, @dvf.

@dvf
Copy link
Owner

dvf commented Oct 2, 2017

@marius92mc ah I didn't know that. Ok great!

@dvf dvf merged commit d301492 into dvf:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marius92mc @dvf