Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dfs-plates-and-dimensions): plates and dimensions dfs work #1753

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
567c6a8
feat(cb2-14454): add feature flags
pbardy2000 Jan 31, 2025
8bc1ac9
feat(CB2-14456-plates-dfs): initial commit
tomcrawleyy Feb 3, 2025
34a8e05
feat(CB2-14454-dimensions): dimensions changes
pbardy2000 Feb 3, 2025
7874612
feat(CB2-14454-dimensions): use correct error messages
pbardy2000 Feb 4, 2025
d2a07f2
feat(CB2-14454-dimensions): add warning message
pbardy2000 Feb 4, 2025
beb3261
Merge branch 'develop' into feat/CB2-14454-dimensions
pbardy2000 Feb 4, 2025
509abff
feat(CB2-14456-plates-dfs-view): view mode (#1751)
tomcrawleyy Feb 5, 2025
5ac4366
feat(CB2-14456-plates-dfs): edit mode
tomcrawleyy Feb 5, 2025
2ba7c70
feat(CB2-14454-dimensions): remove axle logic
pbardy2000 Feb 5, 2025
9be1f9c
feat(CB2-14456-plates-dfs): unit testing
tomcrawleyy Feb 5, 2025
7b2e829
feat(CB2-14456-plates-dfs): rebase against dev
tomcrawleyy Feb 5, 2025
a460b4c
feat(CB2-14456-plates-dfs): remove unnecessary code
tomcrawleyy Feb 5, 2025
f904419
feat(CB2-14454-dimensions): fix add axle for dimensions component
pbardy2000 Feb 5, 2025
aabbc64
feat(CB2-14454-dimensions): fix accessibility issue
pbardy2000 Feb 5, 2025
8b38fe1
feat(CB2-14456-plates-dfs): remove summary component
tomcrawleyy Feb 6, 2025
888fbc5
feat(CB2-14454-dimensions): automation changes
pbardy2000 Feb 6, 2025
c5aefcd
feat(CB2-14454-dimensions): automation changes
pbardy2000 Feb 6, 2025
bf6a9b5
Merge branch 'feat/CB2-14454-dimensions' into feat/dfs-plates-and-dim…
pbardy2000 Feb 6, 2025
e5ee053
feat(dfs-plates-and-dimensions): fix styling
pbardy2000 Feb 6, 2025
8c9c540
feat(dfs-plates-and-dimensions): fix unit tests
pbardy2000 Feb 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,21 @@
</ng-container>

<ng-container *ngSwitchCase="'dimensionsSection'">
<app-dimensions
*ngIf="
techRecordEdited.techRecord_vehicleType === 'hgv' ||
techRecordEdited.techRecord_vehicleType === 'psv' ||
techRecordEdited.techRecord_vehicleType === 'trl'
"
[techRecord]="techRecordEdited"
></app-dimensions>
<ng-container *ngIf="
techRecordEdited.techRecord_vehicleType === 'hgv' ||
techRecordEdited.techRecord_vehicleType === 'psv' ||
techRecordEdited.techRecord_vehicleType === 'trl'
">
<!-- New Dimensions section -->
<ng-container *ngIf="featureToggleService.isFeatureEnabled('FsDimensions'); else oldDimensionsSection">
<app-dimensions-section [techRecord]="techRecordEdited" mode="summary"></app-dimensions-section>
</ng-container>

<!-- Old Dimensions section -->
<ng-template #oldDimensionsSection>
<app-dimensions [techRecord]="techRecordEdited" mode="summary"></app-dimensions>
</ng-template>
</ng-container>
</ng-container>

<ng-container *ngSwitchCase="'approvalSection'">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,25 @@
</ng-container>

<ng-container *ngSwitchCase="'dimensionsSection'">
<app-dimensions
*ngIf="
techRecordCalculated.techRecord_vehicleType === 'trl' ||
techRecordCalculated.techRecord_vehicleType === 'hgv' ||
techRecordCalculated.techRecord_vehicleType === 'psv'
"
[techRecord]="techRecordCalculated"
[isEditing]="(isEditing$ | async) ?? false"
(formChange)="handleFormState($event)"
></app-dimensions>
<ng-container *ngIf="
techRecordCalculated.techRecord_vehicleType === 'trl' ||
techRecordCalculated.techRecord_vehicleType === 'hgv' ||
techRecordCalculated.techRecord_vehicleType === 'psv'
">
<!-- New dimensions section-->
<ng-container *ngIf="featureToggleService.isFeatureEnabled('FsDimensions'); else oldDimensionsSection">
<app-dimensions-section [techRecord]="techRecordCalculated" [mode]="(isEditing$ | async) ? 'edit' : 'view'"></app-dimensions-section>
</ng-container>

<!-- Old dimensions section-->
<ng-template #oldDimensionsSection>
<app-dimensions
[techRecord]="techRecordCalculated"
[isEditing]="(isEditing$ | async) ?? false"
(formChange)="handleFormState($event)"
></app-dimensions>
</ng-template>
</ng-container>
</ng-container>

<ng-container *ngSwitchCase="'approvalSection'">
Expand Down Expand Up @@ -172,12 +181,23 @@
</ng-container>

<ng-container *ngSwitchCase="'platesSection'">
<app-plates
*ngIf="techRecordCalculated.techRecord_vehicleType === 'hgv' || techRecordCalculated.techRecord_vehicleType === 'trl'"
[techRecord]="techRecordCalculated"
[isEditing]="(isEditing$ | async) ?? false"
(formChange)="handleFormState($event)"
></app-plates>
<ng-container *ngIf="techRecordCalculated.techRecord_vehicleType === 'hgv' || techRecordCalculated.techRecord_vehicleType === 'trl'">
<!-- New Plates Section -->
<ng-container *ngIf="featureToggleService.isFeatureEnabled('FsPlates'); else oldPlatesSection">
<app-plates-section
[techRecord]="techRecordCalculated"
[mode]="(isEditing$ | async) ? 'edit' : 'view'"/>
</ng-container>
<!-- Old Plates Section -->
<ng-template #oldPlatesSection>
<app-plates
*ngIf="techRecordCalculated.techRecord_vehicleType === 'hgv' || techRecordCalculated.techRecord_vehicleType === 'trl'"
[techRecord]="techRecordCalculated"
[isEditing]="(isEditing$ | async) ?? false"
(formChange)="handleFormState($event)"
></app-plates>
</ng-template>
</ng-container>
</ng-container>

<ng-container *ngSwitchCase="'adrSection'">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export class NumberInputComponent extends BaseControlComponent implements AfterC
return `govuk-input ${this.width ? `govuk-input--width-${this.width}` : ''}`;
}

// @TODO: remove this when dimensions feature flag is removed
get getWarningMessage(): string {
if (this.isCorrectVehicleType()) {
if (this.shouldDisplayLengthWarning())
Expand All @@ -31,13 +32,17 @@ export class NumberInputComponent extends BaseControlComponent implements AfterC
return '';
}

// @TODO: remove this when dimensions feature flag is removed
shouldDisplayLengthWarning(): boolean {
return this.label === 'Length' && Number.parseInt(this.value, 10) > 12000;
}

// @TODO: remove this when dimensions feature flag is removed
shouldDisplayWidthWarning(): boolean {
return this.label === 'Width' && Number.parseInt(this.value, 10) > 2600;
}

// @TODO: remove this when dimensions feature flag is removed
isCorrectVehicleType(): boolean {
return this.vehicleType === 'hgv' || this.vehicleType === 'trl';
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,199 @@
<ng-container *ngIf="techRecord() as tr">
<ng-container *ngIf="tr.techRecord_vehicleType === VehicleTypes.HGV || tr.techRecord_vehicleType === VehicleTypes.PSV || tr.techRecord_vehicleType === VehicleTypes.TRL">
<div class="main-dimensions" [formGroup]="form">
<!-- Height (PSV only)-->
<govuk-form-group-input
*ngIf="tr.techRecord_vehicleType === VehicleTypes.PSV"
formControlName="techRecord_dimensions_height"
label="Height"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>

<!-- Length-->
<govuk-form-group-input
formControlName="techRecord_dimensions_length"
label="Length"
[width]="Widths.XS"
suffix="mm"
type="number"
[tags]="tr.techRecord_vehicleType === VehicleTypes.PSV
? []
: [{ colour: TagType.PURPLE, label: TagTypeLabels.PLATES }]"
></govuk-form-group-input>

<!-- Width-->
<govuk-form-group-input
formControlName="techRecord_dimensions_width"
label="Width"
[width]="Widths.XS"
suffix="mm"
type="number"
[tags]="tr.techRecord_vehicleType === VehicleTypes.PSV
? []
: [{ colour: TagType.PURPLE, label: TagTypeLabels.PLATES }]"
></govuk-form-group-input>

<!-- Front axle to rear axle-->
<govuk-form-group-input
formControlName="techRecord_frontAxleToRearAxle"
label="Front axle to rear axle"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>

<!-- Rear axle to rear trailer (TRL only) -->
<govuk-form-group-input
*ngIf="tr.techRecord_vehicleType === VehicleTypes.TRL"
formControlName="techRecord_rearAxleToRearTrl"
label="Rear axle to rear trailer"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>

<!-- Axles spacings (HGV and TRL) -->
<ng-container *ngIf="tr.techRecord_vehicleType !== VehicleTypes.PSV" formArrayName="techRecord_dimensions_axleSpacing">
<ng-container *ngFor="let axle of axleSpacings?.controls; let i = index" [formGroup]="axle">
<govuk-form-group-input
[id]="'techRecord_dimensions_axleSpacing_' + i + '_value'"
formControlName="value"
label="Axle {{ i + 1 }} to axle {{ i + 2 }} (mm)"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>
</ng-container>
</ng-container>

<!-- TRL only fields -->
<ng-container *ngIf="tr.techRecord_vehicleType === VehicleTypes.TRL">
<div class="min-max-container">
<span class="govuk-label govuk-label--m">
Coupling center to rear axle
</span>

<div class="min-max">
<!-- Coupling center to rear axle minimum -->
<govuk-form-group-input
formControlName="techRecord_couplingCenterToRearAxleMin"
label="Minimum"
[width]="Widths.XS"
suffix="mm"
type="number"
[tags]="tr.techRecord_vehicleType === VehicleTypes.TRL
? [{ colour: TagType.PURPLE, label: TagTypeLabels.PLATES }]
: []"
></govuk-form-group-input>

<!-- Coupling center to rear axle maximum -->
<govuk-form-group-input
formControlName="techRecord_couplingCenterToRearAxleMax"
label="Maximum"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>
</div>
</div>

<div class="min-max-container">
<span class="govuk-label govuk-label--m">
Coupling center to rear trailer
</span>

<app-field-warning-message [warningMessage]="couplingCenterToRearTrlWarning"></app-field-warning-message>

<div class="min-max">
<!-- Coupling center to rear trailer minimum -->
<govuk-form-group-input
formControlName="techRecord_couplingCenterToRearTrlMin"
label="Minimum"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>

<!-- Coupling center to rear trailer maximum -->
<govuk-form-group-input
formControlName="techRecord_couplingCenterToRearTrlMax"
label="Maximum"
[width]="Widths.XS"
suffix="mm"
type="number"
[tags]="tr.techRecord_vehicleType === VehicleTypes.TRL
? [{ colour: TagType.PURPLE, label: TagTypeLabels.PLATES }]
: []"
></govuk-form-group-input>
</div>
</div>

<!-- Center of rear axle to rear of trailer -->
<govuk-form-group-input
formControlName="techRecord_centreOfRearmostAxleToRearOfTrl"
label="Center of rear axle to rear of trailer"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>
</ng-container>

<!-- HGV only fields -->
<ng-container *ngIf="tr.techRecord_vehicleType === VehicleTypes.HGV">
<div class="min-max-container">
<span class="govuk-label govuk-label--m">
Front of vehicle to 5th wheel coupling
</span>

<div class="min-max">
<!-- Front of vehicle to 5th wheel coupling minimum -->
<govuk-form-group-input
formControlName="techRecord_frontVehicleTo5thWheelCouplingMin"
label="Minimum"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>

<!-- Front of vehicle to 5th wheel coupling maximum -->
<govuk-form-group-input
formControlName="techRecord_frontVehicleTo5thWheelCouplingMax"
label="Maximum"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>
</div>
</div>

<div class="min-max-container">
<span class="govuk-label govuk-label--m">
Front axle to 5th wheel
</span>

<div class="min-max">
<!-- Front axle to 5th wheel minimum -->
<govuk-form-group-input
formControlName="techRecord_frontAxleTo5thWheelMin"
label="Minimum"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>

<!-- Front axle to 5th wheel maximum -->
<govuk-form-group-input
formControlName="techRecord_frontAxleTo5thWheelMax"
label="Maximum"
[width]="Widths.XS"
suffix="mm"
type="number"
></govuk-form-group-input>
</div>
</div>
</ng-container>
</div>
</ng-container>
</ng-container>
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
:host {
display: flex;
flex-flow: column wrap;
gap: 0rem 1rem;

.min-max-container {
display: flex;
flex-flow: column wrap;
gap: 0 1rem;

.extra-margin {
margin-top: 2rem;
}
}

.main-dimensions,
.min-max {
display: flex;
flex-flow: row wrap;
gap: 0rem 1rem;

> * {
min-width: 245px;
}
}
}
Loading