Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

MES-4386: Screens for Category A Mod1 #1091

Merged
merged 11 commits into from
Jan 13, 2020
Merged

Conversation

szabikr
Copy link
Contributor

@szabikr szabikr commented Jan 10, 2020

Description

All the screens which are needed for category A Mod1.

The changes have been reviewed already. But look out for any missing TODOs or any names that are incorrect.

Checklist

  • PR title includes the JIRA ticket number
  • Branch is rebased against the latest develop
  • Code has been tested manually
  • PR link added to JIRA ticket
  • One review from each scrum team
  • Squashed commit contains the JIRA ticket number

Screenshots (optional)

Copy link
Contributor

@edwardwilson edwardwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked for TODO's regarding moving to AMod1 types again and all looks good!

Copy link
Contributor

@TomBillingtonUK TomBillingtonUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good put comments on the things I spotted

szabikr and others added 11 commits January 13, 2020 10:58
* Mes-4387 communication page created for cat-a-mod1
#1070)

* Creating test report page for a-mod1 and removing components

* Adding TODO
* Mes-4388 created health declaration page for cat-a mod1
* Creating non pass finalisation screen for cat a mod1

* Fixing unit tests

* MES-4386: Changing describe name on a test
* Mes-4394 created page for pass finalisation cat A mod1
* Adding debrief cat a page

* changed to correct file name

* adding todo

* Add comment about future refactor work

Co-authored-by: Szabolcs Keresztes <keresztes.szabolcs93@gmail.com>
@szabikr szabikr merged commit e7cef7e into develop Jan 13, 2020
@szabikr szabikr deleted the feature-category-a-mod1 branch January 13, 2020 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants