This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
MES-4386: Screens for Category A Mod1 #1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardwilson
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked for TODO's regarding moving to AMod1 types again and all looks good!
TomBillingtonUK
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good put comments on the things I spotted
src/pages/back-to-office/cat-a-mod1/_tests_/back-to-office.cat-a-mod1.page.spec.ts
Outdated
Show resolved
Hide resolved
src/pages/back-to-office/cat-a-mod1/back-to-office.cat-a-mod1.page.html
Outdated
Show resolved
Hide resolved
...ges/non-pass-finalisation/cat-a-mod1/__tests__/non-pass-finalisation.cat-a-mod1.page.spec.ts
Outdated
Show resolved
Hide resolved
* Mes-4387 communication page created for cat-a-mod1
#1070) * Creating test report page for a-mod1 and removing components * Adding TODO
* Mes-4388 created health declaration page for cat-a mod1
* Creating non pass finalisation screen for cat a mod1 * Fixing unit tests * MES-4386: Changing describe name on a test
* Mes-4394 created page for pass finalisation cat A mod1
* Adding debrief cat a page * changed to correct file name * adding todo * Add comment about future refactor work Co-authored-by: Szabolcs Keresztes <keresztes.szabolcs93@gmail.com>
szabikr
force-pushed
the
feature-category-a-mod1
branch
from
January 13, 2020 10:58
486dcd1
to
ed7da3d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the screens which are needed for category A Mod1.
The changes have been reviewed already. But look out for any missing TODOs or any names that are incorrect.
Checklist
Screenshots (optional)