Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests called specifying environment #439

Merged
merged 8 commits into from
Nov 8, 2024
Merged

fix: tests called specifying environment #439

merged 8 commits into from
Nov 8, 2024

Conversation

fibble
Copy link
Contributor

@fibble fibble commented Nov 7, 2024 •
edited
Loading

Description

  • Snyk exclude for dependency we have a ticket up upgrade soon.

  • Specify environment for test pipeline steps

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@fibble fibble requested review from ilindsay and a team as code owners November 7, 2024 16:29
@fibble fibble changed the title Tests called with env fix: tests called specifying environment Nov 7, 2024
sdh100shaun
sdh100shaun reviewed Nov 8, 2024
View reviewed changes
app/api/.snyk Outdated Show resolved Hide resolved
Wi11Shell
Wi11Shell previously approved these changes Nov 8, 2024
View reviewed changes
@fibble fibble merged commit e4503ed into main Nov 8, 2024
21 checks passed
@fibble fibble deleted the tests-called-with-env branch November 8, 2024 11:14
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Merged
@fibble fibble mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wi11Shell Wi11Shell Wi11Shell approved these changes

@sr4850 sr4850 sr4850 approved these changes

@ilindsay ilindsay Awaiting requested review from ilindsay ilindsay is a code owner

@sdh100shaun sdh100shaun Awaiting requested review from sdh100shaun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fibble @sdh100shaun @sr4850 @Wi11Shell